Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user for cli image. #7450

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Add user for cli image. #7450

merged 1 commit into from
Sep 14, 2018

Conversation

torounit
Copy link
Member

@torounit torounit commented Jun 21, 2018 •
edited
Loading

Description

Add user xfs for cli docker image.
cli user www-data. But user of mounted volume is xfs. So unable to create directory and file from cli commands.

see: docker-library/wordpress#256

How has this been tested?

$ docker-compose run cli wp plugin install wordpress-importer

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

pento
pento approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I'd totally been running into this problem. Thank you for the simple fix, @torounit!

@pento pento merged commit 999f964 into WordPress:master Sep 14, 2018
@mtias mtias added this to the 3.9 milestone Sep 14, 2018
@mtias mtias added the [Type] Build Tooling Issues or PRs related to build tooling label Sep 14, 2018
@torounit torounit deleted the fix/docker-compose-cli branch October 24, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pento pento pento approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
3.9
Development

Successfully merging this pull request may close these issues.
3 participants
@torounit @pento @mtias