Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rememo dependency to 3.0.0 #6767

Merged
merged 1 commit into from
May 16, 2018
Merged

Upgrade rememo dependency to 3.0.0 #6767

merged 1 commit into from
May 16, 2018

Conversation

noisysocks
Copy link
Member

@noisysocks noisysocks commented May 16, 2018 •
edited
Loading

Description

This PR upgrades our rememo dependency to the latest version.

This is useful because it means we will get access to getDependants which was added in 3.0.0.

The only breaking change is that the second argument of createSelector now must return an array. I confirmed that this is the case throughout our codebase.

How has this been tested?

  1. npm install; npm test
  2. Click through the editor and demo post and perform a quick smoke test

@noisysocks noisysocks added the Framework Issues related to broader framework topics, especially as it relates to javascript label May 16, 2018
gziolo
gziolo approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@noisysocks noisysocks merged commit 53809ae into master May 16, 2018
@noisysocks noisysocks deleted the update/rememo branch May 16, 2018 06:53
@gziolo gziolo added this to the 2.9 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@aduth aduth Awaiting requested review from aduth

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

Assignees
No one assigned
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@noisysocks @gziolo