Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonGroup: Fix story to show what the component does #65336

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Sep 13, 2024

What?

Tweaks the ButtonGroup story so it actually highlights what the component does (styling).

Why?

In the current story, the buttons have a margin, and that doesn't show how the ButtonGroup component handles styling to make them look like a single segmented control.

Testing Instructions

See Storybook story for ButtonGroup.

Screenshots or screencast

Before After
ButtonGroup story, before ButtonGroup story, after

@mirka mirka added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components Storybook Storybook and its stories for components labels Sep 13, 2024
@mirka mirka requested a review from a team September 13, 2024 18:34
@mirka mirka self-assigned this Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka mirka mentioned this pull request Sep 13, 2024
2 tasks
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found where this was introduced: #17910, which makes me wonder if anyone really know what this component was for

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants