-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Make React Fast Refresh Work with multiple blocks #64924
base: trunk
Are you sure you want to change the base?
Conversation
@@ -302,6 +302,15 @@ class DependencyExtractionWebpackPlugin { | |||
assetData.type = 'module'; | |||
} | |||
|
|||
if ( compilation.options?.optimization?.runtimeChunk !== false ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it also be different than undefined
?
Size Change: 0 B Total Size: 1.78 MB ℹ️ View Unchanged
|
@@ -302,6 +302,15 @@ class DependencyExtractionWebpackPlugin { | |||
assetData.type = 'module'; | |||
} | |||
|
|||
if ( compilation.options?.optimization?.runtimeChunk !== false ) { | |||
assetData.handle = | |||
uniqueName + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, the unique name might not be defined based on the failing unit tests. By the way, this change will most likely require updating test snapshots as sometimes the handle is going to be printed.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast