Dataviews docs: Layout properties checks and link #64918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
juanmaguitar
added
[Type] Developer Documentation
oandregal
reviewed
Aug 30, 2024
| - `children`: a list of field's `id` to combine | ||
| - `direction`: how should they be stacked, `vertically` or `horizontally` | ||
| - `children`: a list of field's `id` to combine | ||
| - `direction`: how should they be stacked, `vertically` or `horizontally` |
There was a problem hiding this comment.
I mistyped this in the original docs PR, it should be:
Suggested change
| - `direction`: how should they be stacked, `vertically` or `horizontally` | |
| - `direction`: how should they be stacked, `vertical` or `horizontal` |
There was a problem hiding this comment.
Prepared a follow-up PR to fix this typo: #64973
oandregal
approved these changes
Aug 30, 2024
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
* fix check icons * defaultLayouts clarification and link to properties of layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes checks in the table and add a link to the table so it can be referenced from other parts of the page
Why?
The table at https://developer.wordpress.org/block-editor/reference-guides/packages/packages-dataviews/#view-object doesn't show properly the checks.
The information of this table is a great reference for other parts of the docs so a link to this part would be helpful.