Composite: add Hover and Typeahead subcomponents #64399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] New API
ciampo
commented
Aug 9, 2024
ciampo
commented
Aug 9, 2024
Comment on lines
+223
to
+280
| decorators: [ | ||
| ( Story ) => { | ||
| return ( | ||
| <> | ||
| { /* Visually style the active composite item */ } | ||
| <style>{ ` | ||
| [data-active-item] { | ||
| background-color: #ffc0b5; | ||
| } | ||
| ` }</style> | ||
| <Story /> | ||
| <div | ||
| style={ { | ||
| marginTop: '2em', | ||
| fontSize: '12px', | ||
| fontStyle: 'italic', | ||
| } } | ||
| > | ||
| { /* eslint-disable-next-line no-restricted-syntax */ } | ||
| <p id="list-title">Notes</p> | ||
| <ul aria-labelledby="list-title"> | ||
| <li> | ||
| The active composite item is highlighted with a | ||
| different background color; | ||
| </li> | ||
| <li> | ||
| A composite item can be the active item even | ||
| when it doesn't have keyboard focus. | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| </> | ||
| ); | ||
| }, | ||
| ], |
There was a problem hiding this comment.
This decorator helps to visually identify the active composite item. It is particularly useful in the Hover example, where composite items become "active" on hover without receiving keyboard focus.
ciampo
force-pushed
the
feat/stabilize-composite/add-subcomponents
branch
from
100199b
to
4c1fab4
Compare
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Composite: add Hover and Typeahead subcomponents * Add hover example + styles to highlight active item * Add Composite.Hover props docs * Add Typeahead docs and Storybook example * CHANGELOG * Remove the `focusOnHover` and `blurOnHoverEnd` props. * Remove ariakit references * Add import statements to code examples --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #63564
Add
Composite.HoverandComposite.TypeaheadcomponentsWhy?
To improve the offering of the
Compositecomponent.These components are also already used in the repository (imported directly from
ariakit). Adding them toCompositewill allow us to replace those imports with imports from@wordpress/components.How?
Testing Instructions
Compositecomponent, and play around with the newHoverandTypeaheadexamplesThis PR doesn't include runtime changes to the actual component.