Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Comments Form: Add Border Block Support #64233

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Aug 4, 2024

What?

Add border block support to the Post Comment Form block.

Part of #43247

Why?

Post Comment Form block is missing border support.

How?

Adds the border block support in block.json.

Testing Instructions

  • Go to Global Styles Settings ( Under Appearance > Editor > Styles > Edit styles > Blocks ).
  • Make sure that Post Comment Form block's border is Configurable via Global Styles.
  • Edit template/page, Add Post Comment Form block and Apply the border Styles.
  • Verify that Post Comment Form block styles take precedence over global Styles.
  • Verify that Post Comment Form block borders display correctly in both the Editor and Frontend.

Screenshots or Screencast

add-border-support-in-post-comment-forms.mp4

@shail-mehta shail-mehta added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Comments Form Affects the Comments Form Block labels Aug 4, 2024
@shail-mehta shail-mehta self-assigned this Aug 4, 2024
@shail-mehta shail-mehta marked this pull request as draft August 4, 2024 08:23
Copy link

github-actions bot commented Aug 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta marked this pull request as ready for review August 4, 2024 09:09
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • ✅Global styles are applied correctly.
  • ✅Styles are consistent between the editor and the front end.
  • ✅Can override styles from block instances.
  • box-sizing is already applied.

One thing I noticed is that the corners of the border are sometimes hidden by the placeholder when it's visible, i.e. when comments are disabled. However, this also happens with other blocks, so I don't think it's necessarily a bug that needs to be fixed, and I think it can be addressed in a follow-up if necessary.

image

@t-hamano t-hamano merged commit 5693867 into trunk Aug 7, 2024
73 checks passed
@t-hamano t-hamano deleted the add/comment-form-border-support branch August 7, 2024 02:51
@github-actions github-actions bot added this to the Gutenberg 19.0 milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Comments Form Affects the Comments Form Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants