Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Links: Add border block support #63629

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

akasunil
Copy link
Member

@akasunil akasunil commented Jul 16, 2024

What?

Add border block support to the Social Links block.

Part of #43247

Why?

Social Links block is missing border support.

How?

Adds the border block support in block.json

Testing Instructions

  • Go to Global Styles setting ( under appearance > editor > styles > edit styles > blocks )
  • Make sure that Social Links border is configurable via Global Styles
  • Verify that Global Styles are applied correctly in the editor and frontend
  • Edit template/page, Add Social Links block and Apply the border styles
  • Verify that block borders take precedence over global styles
  • Verify that block borders display correctly in both the editor and frontend

Screenshots or screencast

In backend:
Screenshot at Jul 16 22-13-28

In frontend:
Screenshot at Jul 16 22-13-39

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Social Affects the Social Block - used to display Social Media accounts labels Jul 16, 2024
@akasunil akasunil requested a review from ajitbohra as a code owner July 16, 2024 16:51
Copy link

github-actions bot commented Jul 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping into the design tool consistency efforts @akasunil 🙇

This PR tests as advertised for me and helps round out the Social Links design tools given the block already supports background color and padding.

✅ Social Links border is configurable via Global Styles
✅ Global Styles apply correctly in the editor and frontend
✅ Block instance borders take precedence over global styles
✅ Block instance borders display correctly in both the editor and frontend

Screen.Recording.2024-07-17.at.3.54.39.PM.mp4

Nice work! I'll get this merged and update the border tracking issue accordingly.

P.S. To help encourage others that may be less familiar with global styles and block supports, would you mind updating the PR description here, and the other open block support PRs, with more detailed test instructions? Ensuring the block support adoption works correctly is slightly more involved than the current instructions suggest, that's all.

@aaronrobertshaw aaronrobertshaw merged commit d1211ff into trunk Jul 17, 2024
68 checks passed
@aaronrobertshaw aaronrobertshaw deleted the add/sociallinks-border-support branch July 17, 2024 06:06
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 17, 2024
@akasunil
Copy link
Member Author

To help encourage others that may be less familiar with global styles and block supports, would you mind updating the PR description here, and the other open block support PRs, with more detailed test instructions?

Sure thing!

carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants