Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Styles: Remove core block style variations filters and action #62090

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

aaronrobertshaw
Copy link
Contributor

What?

Removes any core block style variation filters and actions so we don't double up on those in Gutenberg.

Why?

Avoid foreseeable bugs 🐛 🐞

How?

If core's equivalent of the filter function exists, remove the filter or action.

Testing Instructions

Detailed test instructions are included on the original section styling PR: #57908

The main points to check are that block style variations can be registered by:

  1. Theme.json partials in the /styles directory
  2. Primary theme.json file under styles.blocks.variations
  3. Theme style variations via styles.blocks.variationsa
  4. The PHP register_block_style function

@aaronrobertshaw aaronrobertshaw added [Type] Bug An existing feature does not function as intended [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks labels May 29, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this May 29, 2024
Copy link

github-actions bot commented May 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/block-supports/block-style-variations.php

@andrewserong andrewserong added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Jun 11, 2024
@aaronrobertshaw aaronrobertshaw force-pushed the fix/block-style-variation-support-filters branch from e10f6cd to 13a472b Compare June 11, 2024 06:23
@aaronrobertshaw aaronrobertshaw enabled auto-merge (squash) June 11, 2024 06:23
@aaronrobertshaw aaronrobertshaw merged commit 48d9364 into trunk Jun 11, 2024
62 checks passed
@aaronrobertshaw aaronrobertshaw deleted the fix/block-style-variation-support-filters branch June 11, 2024 06:58
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 11, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
…ordPress#62090)

Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Co-authored-by: oandregal <oandregal@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants