Patterns page: add edit & view revision actions to parts #60659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
oandregal
requested review from
mcsf,
youknowriad,
jameskoster,
SaxonF,
jorgefilipecosta and
ntsekouras
This was referenced Apr 11, 2024
|
Size Change: +49 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Apr 11, 2024
oandregal
commented
Apr 11, 2024
| const actions = useMemo( () => { | ||
| if ( type === TEMPLATE_PART_POST_TYPE ) { | ||
| return [ | ||
| editAction, |
There was a problem hiding this comment.
I've looked into making the editAction also available to user patterns. I haven't done so in this PR because the edit action eligibility check is post type agnostic and lives in the @wordpress/editor package.
If there's interest I can look into that separately. We'd need to either exclude theme patterns from there or create a specific edit action for user patterns in the site editor package.
mcsf
reviewed
Apr 16, 2024
| } ); | ||
| } | ||
| }, | ||
| [ history ] |
There was a problem hiding this comment.
This is missing deps 'categoryId' and 'type', or was it intentional?
There was a problem hiding this comment.
Oh, thanks for raising, fix at #60784
|
I'm trying to test this out in the Gutenberg 18.2 RC1 that was released on Friday. I'm not able to access anything with the testing instructions: "Visit the Patterns and go down to template parts. Verify that template parts have two new actions available (edit & view revisions) and they work as expected." So far I've tried the following scenarios thinking they might help:
Here are the steps I'm trying for each scenario:
FWIW - I'm seeing the 'Edit', and just not 'View Revisions' 🤔
|
|
@colorful-tones One quirk of the implementation is that the revisions will only be accessible when there's something in the database to revert to. So for theme-supplied assets that means you have to edit them twice. This is because the revisions UI in wp-admin isn't able to entertain the .html files supplied by themes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #59659 #60359
What?
Add the
editandviewRevisionactions to template parts in the patterns page.Why?
These actions are available for Template Parts in the "Manage all template parts" screen. We aim to remove that screen, and one of the previous steps is to migrate all that behavior to the "Patterns" screen.
How?
Testing Instructions
Visit the Patterns and go down to template parts. Verify that template parts have two new actions available (edit & view revisions) and they work as expected.