Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data views: Add click-to-select behavior on table rows #59803

Merged
merged 11 commits into from
Mar 22, 2024
Merged

Data views: Add click-to-select behavior on table rows #59803

merged 11 commits into from
Mar 22, 2024

Commits on Mar 12, 2024

  1. Clicking the checkbox container toggles selection

    @jameskoster
    jameskoster committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b9064d4 View commit details
    Browse the repository at this point in the history

  2. Fix checkboxes

    @jameskoster
    jameskoster committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4880f5d View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Click row to select

    @jameskoster
    jameskoster committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    146418f View commit details
    Browse the repository at this point in the history

  2. Style adjustments

    @jameskoster
    jameskoster committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e3766a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'trunk' into update/data-views-checkbox-hitbox

    @jameskoster
    jameskoster committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6db4bb9 View commit details
    Browse the repository at this point in the history

  2. Demo: allow click-on-row with meta/cmd or when selection already active

    @mcsf
    mcsf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    e2bf36c View commit details
    Browse the repository at this point in the history

  3. Demo: always allow click-on-row, taking care not to catch button clicks

    @mcsf
    mcsf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    242966d View commit details
    Browse the repository at this point in the history

  4. Bonus: disable item actions if a selection is already active

    @mcsf
    mcsf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3541f13 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Revert "Bonus: disable item actions if a selection is already active" 

    This reverts commit 3541f13.
    @jameskoster
    jameskoster committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    fa91886 View commit details
    Browse the repository at this point in the history

  2. Do no select record when selecting text

    @jameskoster
    jameskoster committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    64c4967 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Disable click-to-select on touch devices (use onTouchStart)

    @mcsf
    mcsf committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    be1856a View commit details
    Browse the repository at this point in the history