Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme.json schema: Update appearanceTools description #59499

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Mar 1, 2024

What?

This PR adds the missing setting in the theme.json schema that settings.apperanceTools actually enables:

  • color.heading
  • color.button
  • color.caption
  • shadow.defaultPresets

How?

Referenced APPEARANCE_TOOLS_OPT_INS variable and added missing settings.

Testing Instructions

Create a JSON file like below locally and make sure settings.apperanceTools displays the correct description text.

{
	"$schema": "https://github.com/WordPress/gutenberg/theme-json/update-appearance-tools/schemas/json/theme.json",
	"version": 2,
	"settings": {
		"appearanceTools": false
	}
}

Screenshots or screencast

Before

image

After

image

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Mar 1, 2024
@t-hamano t-hamano self-assigned this Mar 1, 2024
@t-hamano t-hamano marked this pull request as ready for review March 1, 2024 12:21
Copy link

github-actions bot commented Mar 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

@t-hamano t-hamano merged commit 0b417ca into trunk Mar 2, 2024
64 checks passed
@t-hamano t-hamano deleted the theme-json/update-appearance-tools branch March 2, 2024 00:50
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Mar 2, 2024
@andrewserong
Copy link
Contributor

Thanks for updating!

@madhusudhand
Copy link
Member

Thank you for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants