Remove preferred style variations legacy support #58930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
ellatrix,
geriux,
ajitbohra,
ajlende,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
youknowriad
requested review from
talldan,
glendaviesnz and
ramonjd
and removed request for
juanmaguitar,
ajitbohra,
ryanwelcher,
ellatrix,
ndiego,
geriux,
ajlende and
fabiankaegy
|
Size Change: -722 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
cleanup/preferred-style-variations
branch
from
b9979bb
to
e7c8a59
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
cleanup/preferred-style-variations
branch
from
e7c8a59
to
d824d42
Compare
ramonjd
approved these changes
Feb 13, 2024
|
I forgot the props, sorry about that :) |
|
I have a question regarding this... |
aristath
added a commit
that referenced
this pull request
Feb 13, 2024
* trunk: (273 commits) Remove preffered style variations legacy support (#58930) Style theme variations: add property extraction and merge utils (#58803) Migrate `change-detection` to Playwright (#58767) Update Changelog for 17.6.6 Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915) Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943) Try double enter for details block. (#58903) Template revisions API: move from experimental to compat/6.4 (#58920) Editor: Remove inline toolbar preference (#58945) Clean up link control CSS. (#58934) Font Library: Show error message when no fonts found to install (#58914) Block Bindings: lock editing of blocks by default (#58787) Editor: Remove the 'all' rendering mode (#58935) Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189) Close link preview if collapsed selection when creating link (#58896) Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900) Upgrade Floating UI packages, fix nested iframe positioning bug (#58932) Site editor: fix start patterns store selector (#58813) Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792) Documentation: Clarify the performance reference commit and how to pick it (#58927) ...
|
All what I'm saying in this PR is that the legacy support we kept was broken (not consistent) and I removed it from the code. I don't know much about future plans. From my own perspective, future plans would probably include marking variations as preferred on the global styles level, so not a preference which means it might work differently. |
creativecoder
added
the
[Feature] Theme Style Variations
|
Note that as part of curating the Gutenberg 17.8 changelog, I added the label [Feature] Style Variations to this PR to better categorize it. Please let me know if there is a different label that would be a better fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
In #34522 we removed the "preferred style variations" feature from Gutenberg but we kept it around for users that had switched the default variation for some blocks. The problem though is that it is not being applied consistently, for example, it's applied in the post editor but not the site editor or widgets editor..., so the value of that fallback is actually not great.
This PR just goes ahead and removes it entirely. It keeps the action around with a deprecated message but from now on, the default variation is the default one specified by Core for everyone.
We may one to have something like it in the future but it will be global styles based instead of a preference.
Testing Instructions
Nothing really to test here.