Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript #58859

Conversation

cbravobernal
Copy link
Contributor

@cbravobernal cbravobernal commented Feb 8, 2024

What?

Copy of already reviewed PR in Core, as the cherry-pick was failing due to a missing import in load.php.
#58818

Chore to release Gutenberg 17.6.5

cbravobernal and others added 9 commits February 8, 2024 18:39
…pt (#58818)

* Add fix from Core Trunk to Gutenberg

* Move to 6.5 compat folder

Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
…pt (#58818)

* Add fix from Core Trunk to Gutenberg

* Move to 6.5 compat folder

Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
…pt (#58818)

* Add fix from Core Trunk to Gutenberg

* Move to 6.5 compat folder

Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@cbravobernal cbravobernal added this to the Gutenberg 17.6 milestone Feb 8, 2024
@cbravobernal cbravobernal added [Type] Bug An existing feature does not function as intended [Feature] Script Modules API Related to the Script Modules API that adds support for native ES modules and import maps labels Feb 8, 2024
@cbravobernal cbravobernal self-assigned this Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/script-loader.php
❔ lib/compat/wordpress-6.5/class-wp-script-modules.php
❔ lib/load.php

@cbravobernal cbravobernal merged commit e449798 into release/17.6 Feb 8, 2024
30 of 54 checks passed
@cbravobernal cbravobernal deleted the fix/import-map-loading-not-html5-templates-with-loader branch February 8, 2024 20:40
@cbravobernal cbravobernal changed the title Modules API Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Script Modules API Related to the Script Modules API that adds support for native ES modules and import maps [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant