Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style engine: support nested CSS rules (or CSS containers) #58797

Closed
wants to merge 20 commits into from
Closed

Style engine: support nested CSS rules (or CSS containers) #58797

wants to merge 20 commits into from

Commits on Feb 10, 2024

  1. First commit

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    4d77e49 View commit details
    Browse the repository at this point in the history

  2. Tests

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    17afecc View commit details
    Browse the repository at this point in the history

  3. Extracting file 

     #
Clean up after rebase

Clean up after rebase
    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    794d4d9 View commit details
    Browse the repository at this point in the history

  4. Refactor output public API methods in style-engine 

    Ensuring we can add rule objects to store
Tests
new container class
    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5bea1a6 View commit details
    Browse the repository at this point in the history

  5. Store containers in the store. No need to store container names on th… 

    …e rules.
    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    08211cc View commit details
    Browse the repository at this point in the history

  6. Revert changes to WP_Style_Engine_CSS_Rule

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    cafcbc6 View commit details
    Browse the repository at this point in the history

  7. Formatting

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    63ef366 View commit details
    Browse the repository at this point in the history

  8. Added container tests

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    0514b53 View commit details
    Browse the repository at this point in the history

  9. linting

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    332bc86 View commit details
    Browse the repository at this point in the history

  10. Added empty test

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    63b29de View commit details
    Browse the repository at this point in the history

  11. Format

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    e6be2cc View commit details
    Browse the repository at this point in the history

  12. Adding more test examples for wp_engine_get_stylesheet_from_css_rules

    @ramonjd
    ramonjd committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    66063d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Remove TODOs 

    Store combines existing rules

Store combines
    @ramonjd
    ramonjd committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    081de82 View commit details
    Browse the repository at this point in the history

  2. Remove unused properties of container class

    @ramonjd
    ramonjd committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5276e36 View commit details
    Browse the repository at this point in the history

  3. Lint me

    @ramonjd
    ramonjd committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    eb5797c View commit details
    Browse the repository at this point in the history

  4. Some notes

    @ramonjd
    ramonjd committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    4dcdc8b View commit details
    Browse the repository at this point in the history

  5. linty

    @ramonjd
    ramonjd committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    b10ef34 View commit details
    Browse the repository at this point in the history

  6. Tidy up store and add tests

    @ramonjd
    ramonjd committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    1737f72 View commit details
    Browse the repository at this point in the history

  7. Test for nesting other at-rules

    @ramonjd
    ramonjd committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    84f0f4c View commit details
    Browse the repository at this point in the history

  8. Remove comments

    @ramonjd
    ramonjd committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e69c10d View commit details
    Browse the repository at this point in the history