Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluid typography: pass theme.json settings to override merged theme data #58362

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Fluid typography: pass theme.json settings to override merged theme data #58362

merged 8 commits into from
Mar 4, 2024

Commits on Mar 4, 2024

  1. Allow passing a theme json settings object to the gutenberg_get_typog… 

    …raphy_font_size_value function.

This is so that any stylesheets generated by the Theme_JSON class can use that class's theme_json instance.
    @ramonjd
    ramonjd committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    83634e7 View commit details
    Browse the repository at this point in the history

  2. Harmonizing the function signatures of gutenberg_get_typography_font_… 

    …size_value (PHP) and getTypographyFontSizeValue (JS)

Updated doc comment
    @ramonjd
    ramonjd committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    44f7b1a View commit details
    Browse the repository at this point in the history

  3. Updated comments 

    Light refactoring
Added extra test to check for empty objects/arrays
    @ramonjd
    ramonjd committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    40b16a8 View commit details
    Browse the repository at this point in the history

  4. Forgot that useSettings won't accept top level paths

    @ramonjd
    ramonjd committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    db1c028 View commit details
    Browse the repository at this point in the history

  5. Passing $settings to preset callbacks 

    Added test for the above
    @ramonjd
    ramonjd committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9b9efdc View commit details
    Browse the repository at this point in the history

  6. Linty McLintface

    @ramonjd
    ramonjd committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    d3d7c5c View commit details
    Browse the repository at this point in the history

  7. updating tests, remove hanging isset 

    test
    @ramonjd
    ramonjd committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    2110531 View commit details
    Browse the repository at this point in the history

  8. Oh, linter, how thee hast forsaken thy duty to grate thine users less

    @ramonjd
    ramonjd committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    73ae2ab View commit details
    Browse the repository at this point in the history