Global styles revisions: fix is-selected rules from affecting other areas of the editor #58228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reas of the editor
andrewserong
added
[Type] Bug
andrewserong
commented
Jan 25, 2024
| background: rgba(var(--wp-admin-theme-color--rgb), 0.04); | ||
|
|
||
| .edit-site-global-styles-screen-revisions__revision-button { | ||
| opacity: 1; |
There was a problem hiding this comment.
Just in case anyone else wonders while looking at this: the opacity: 1 rule is required so that the .components-button:disabled opacity of .3 isn't applied here.
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
ramonjd
deleted the
fix/scope-of-is-selected-in-global-styles-revisions-screen
branch
ramonjd
added
the
Backport to WP 6.7 Beta/RC
westonruter
added a commit
that referenced
this pull request
Jan 26, 2024
…zy-hydration * origin/trunk: (47 commits) Interactivity API: Break up long hydration task in interactivity init (#58227) Add supports.interactivity to Query block (#58316) Font Library: Make notices more consistent (#58180) Fix Global styles text settings bleeding into placeholder component (#58303) Fix the position and size of the Options menu, (#57515) DataViews: Fix safari grid row height issue (#58302) Try a fix (#58282) Navigation Submenu Block: Make block name affect list view (#58296) Apply custom scroll style to fixed header block toolbar (#57444) Add support for transform and letter spacing controls in Global Styles > Typography > Elements (#58142) DataViews: Fix table view cell wrapper and BlockPreviews (#58062) Workflows: Add 'Technical Prototype' to the type-related labels list (#58163) Block Editor: Optimize the 'useBlockDisplayTitle' hook (#58250) Remove noahtallen from .wp-env codeowners (#58283) Global styles revisions: fix is-selected rules from affecting other areas of the editor (#58228) Try: Disable text selection for post content placeholder block. (#58169) Remove `template-only` mode from editor and edit-post packages (#57700) Refactored download/upload logic to support font faces with multiple src assets (#58216) Components: Expand theming support in COLORS (#58097) Implementing new UX for invoking rich text Link UI (#57986) ...
|
Thanks for the review Lena, and for merging, Ramon! |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move a few of the rules for selected items in the global styles revisions screen so that they're scoped to the revisions item.
Why?
As flagged in #55913 (review), the existing rules are affecting other areas of the editor (notably the custom color picker button when folks are creating their own color palettes). These rules appear to only have been intended for the global styles revision item.
How?
edit-site-global-styles-screen-revisions__revision-item.is-selectedso that they're scoped to the revision item classname.Testing Instructions
Screenshots or screencast
The color palette regression that's fixed by this PR
It's pretty subtle, but note that in the
trunkscreenshot there is an unintentional subtle blue background.What shouldn't have changed
This is the area where these rules were intended to have an effect. There should be no change to the selected or hovered items in the revisions screen to what's on
trunk: