-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor Settings: use v2 DropdownMenu #57996
base: trunk
Are you sure you want to change the base?
Conversation
Size Change: +4.69 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
3a4da5e
to
587ac58
Compare
587ac58
to
52ff982
Compare
The refactor is moving forward. So far I encountered 3 aspects that need reviewing / discussing: ModalityThe new Thinking about it, though, I wonder if changing the default value to Regardless of modality, I believe that we should make Finally, I wanted to note that ariakit adds some focus traps before and after the dropdown trigger button that interfere with some custom toolbar logic that complains if children of Rendering in the
|
Flaky tests detected in 04d20c3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7623334466
|
What?
Why?
How?
TODO:
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast