-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video: Hide some controls when multi-editing blocks #57375
Conversation
96dd088
to
0cb2036
Compare
Size Change: +89 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Flaky tests detected in 0cb2036. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7329582973
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What?
Part of #57369.
Similar to #57357.
PR updates the Video block to hide the "Caption", "Text tracks", and "Replace" toolbar controls when multi-editing blocks.
Why?
The "Caption" control doesn't work; the other two don't make sense when multi-editing and can cause content loss.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast