Fix fatal error when calling undefined block library function. #56459
Conversation
tellthemachines
added
[Type] Regression
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/class-wp-navigation-block-renderer.php |
There was a problem hiding this comment.
Thanks for the quick fix, and for the helpful testing instructions!
I could reproduce the issue in downgraded 6.3.2 using the latest Gutenberg, with a Navigation block set have sub menus click to open. That resulted in the following error:
With this PR applied, no errors in 6.3.2 or 6.4.1.
LGTM! ✨
tellthemachines
removed
the
Backport to Gutenberg Minor Release
|
Thank you all for fixing this so quickly ❤️ |
|
@scruffian this will require a backport as part of #57979 🙏 |
| $compacted_blocks = block_core_navigation_filter_out_empty_blocks( $parsed_blocks ); | ||
| $compacted_blocks = gutenberg_block_core_navigation_filter_out_empty_blocks( $parsed_blocks ); |
There was a problem hiding this comment.
@scruffian I'm seeing that these references have reverted to block_ prefix in Gutenberg trunk. Can you verify if that was intentional so that we can avoid any regressions here 🙏
There was a problem hiding this comment.
My understanding is that this is now ok because functions being called are now within block-library and indeed within the same file.
There was a problem hiding this comment.
Yeah that's my understanding too, so I think this is fine.
There was a problem hiding this comment.
Yes that's ok! What we shouldn't have is gutenberg_ prefixed functions in block-library.
There was a problem hiding this comment.
That's a good point. I think that's what must have drawn my attention to this change.
@scruffian why are we now using gutenberg_ prefix? Should this be revised as @tellthemachines indicates?
There was a problem hiding this comment.
We don't have the gutenberg_ prefix in the navigation block except where its added by the webpack script.
|
✅ I updated the PHP Sync Tracking Issue for WP 6.5 to note this PR no longer requires a backport for WP 6.5. Why? Because the code was moved into the block-library package in #57979 and thus should be automatically handled by the packages sync process. Also note this discussion. cc @scruffian for confirmation. |
What?
Fixes #56453.
The newly-added
WP_Navigation_Block_Rendererwas calling some block-library functions by their unprefixed names, which will cause a fatal error if those functions happen to not be defined in core. All block library PHP functions are prefixed withgutenberg_at build time, so anywhere they are called outside of block-library (within the plugin) the prefixed version of their name should be used.Testing Instructions
This is a tricky one to test in 6.4.1 because it can only be reproduced on a site that has a Navigation block created from a classic menu some time ago, so that it both has the
__unstableLocationattribute and doesn't have therefone. Essentially we need to make sure that this line runs.An easier way to test is by downgrading to 6.3.2 and making sure there is a Nav with a submenu set to open on click on the page, so that this line runs.
With this PR, there should be no Navigation-related errors in WP 6.4.1 or 6.3.2.