Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server directive processing: Stop processing non-interactive blocks #56302

Merged
merged 42 commits into from
Dec 28, 2023
Merged

Server directive processing: Stop processing non-interactive blocks #56302

merged 42 commits into from
Dec 28, 2023

Commits on Dec 26, 2023

  1. Initial commit

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    18397dc View commit details
    Browse the repository at this point in the history

  2. It works, but is stripping comments

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    7f313a4 View commit details
    Browse the repository at this point in the history

  3. Added an extra return for debugging

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    d6582c4 View commit details
    Browse the repository at this point in the history

  4. Refactor to use string instead of arrays to compare

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    1f8986d View commit details
    Browse the repository at this point in the history

  5. Use hidden textarea to save comments in production html

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    abc0e73 View commit details
    Browse the repository at this point in the history

  6. Use divs as delimiters, comments not working for interactive innner c… 

    …omponents
    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    08bc3bc View commit details
    Browse the repository at this point in the history

  7. Back to array for references and comment delimiters

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    009e5aa View commit details
    Browse the repository at this point in the history

  8. Something is working :-)

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    af92974 View commit details
    Browse the repository at this point in the history

  9. Refactor, process working

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    8bc6184 View commit details
    Browse the repository at this point in the history

  10. experiment replacing inner blocks

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    82c2b16 View commit details
    Browse the repository at this point in the history

  11. now working if there is only 1 interactive block

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    65487d1 View commit details
    Browse the repository at this point in the history

  12. now working with 2 interactive blocks

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    f43d498 View commit details
    Browse the repository at this point in the history

  13. Commented stopping at first custom element, after innerblocks is not … 

    …being processed otherwise
    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    3288fbe View commit details
    Browse the repository at this point in the history

  14. Try using bookmarks, fix autoclosing tag not working

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    cb26cbe View commit details
    Browse the repository at this point in the history

  15. Not using bookmarks anymore, just processing inner inside processing … 

    …function
    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    7e05658 View commit details
    Browse the repository at this point in the history

  16. Seems to be working, still needs a good test battery

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    f23d2e0 View commit details
    Browse the repository at this point in the history

  17. Fix interactivity API directive processing

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    1fc73ae View commit details
    Browse the repository at this point in the history

  18. Remove tests that will be updated in next commits

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    07f819a View commit details
    Browse the repository at this point in the history

  19. Add markup tests

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    30e366e View commit details
    Browse the repository at this point in the history

  20. Use correct div group structure

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    b3063a7 View commit details
    Browse the repository at this point in the history

  21. Small refactor

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    b9ac02c View commit details
    Browse the repository at this point in the history

  22. remove not needed block name in interactive markers

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    35e4d9f View commit details
    Browse the repository at this point in the history

  23. Add more markup tests

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    2761518 View commit details
    Browse the repository at this point in the history

  24. refactor tests

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    b66c522 View commit details
    Browse the repository at this point in the history

  25. Make inner blocks optional

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    6e5c579 View commit details
    Browse the repository at this point in the history

  26. Move directives declaration to declare them only if needed

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    6a9ba8f View commit details
    Browse the repository at this point in the history

  27. Refactor more code, thanks to @DAreRodz

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    90f1c6a View commit details
    Browse the repository at this point in the history

  28. Remove only the first ocurrence

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    51caefd View commit details
    Browse the repository at this point in the history

  29. Improve comments and format

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    bfc0ecd View commit details
    Browse the repository at this point in the history

  30. Update tests to use HTML API, fix non interactive blocks not being pa… 

    …rsed
    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    5a01ef2 View commit details
    Browse the repository at this point in the history

  31. Unmark children of interactive blocks according to @DAreRodz comment

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    f5ac832 View commit details
    Browse the repository at this point in the history

  32. Add a p tag check test

    @cbravobernal
    cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    4843cb7 View commit details
    Browse the repository at this point in the history

  33. Execute directives by priority

    @DAreRodz @cbravobernal
    DAreRodz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    0911938 View commit details
    Browse the repository at this point in the history

  34. Remove gutenberg name from tests and use camelCase for context property

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    aea5f74 View commit details
    Browse the repository at this point in the history

  35. Fix empty style attribute error

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    93be756 View commit details
    Browse the repository at this point in the history

  36. Add test for directive ordering

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    2c0b722 View commit details
    Browse the repository at this point in the history

  37. Fix evaluate should only execute anonymous functions test

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    d500b19 View commit details
    Browse the repository at this point in the history

  38. Fix wp-style tests

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    ec51bda View commit details
    Browse the repository at this point in the history

  39. Improve tests

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    9c0290d View commit details
    Browse the repository at this point in the history

  40. Test that we don't process non-interactive blocks

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    3c00d97 View commit details
    Browse the repository at this point in the history

  41. Stop unmarking children of interactive blocks

    @luisherranz @cbravobernal
    luisherranz authored and cbravobernal committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    22f6131 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Move directives inside gutenberg_process_interactive_html

    @luisherranz
    luisherranz committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    b106720 View commit details
    Browse the repository at this point in the history