Block Editor: Optimize 'Block Hooks' inspector controls #56101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
Size Change: +3 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Nov 14, 2023
tyxla
approved these changes
Nov 14, 2023
|
Thank you all! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #55721.
PR updates the
withBlockHooksControlsfilter to render the "Block Hooks" inspector controls when a block is selected. It is only needed when editing a block.Why?
This is an effort to minimize unnecessary store subscriptions created per block. See #54819 (comment).
Tested using @jsnajdr's debug code (c029303), the store subscriptions are reduced by 2-3k on large text post - 1000 blocks.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast