Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Refactor Popover to focus content wrapper on open #5595

Closed
wants to merge 14 commits into from
Closed

Components: Refactor Popover to focus content wrapper on open #5595

wants to merge 14 commits into from
+299 −159

Commits on Mar 26, 2018

  1. Revert "Components: Restrict Popover focusOnMount to keyboard interac… 

    …tion"

This reverts commit 8f715e0.
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    731177a View commit details
    Browse the repository at this point in the history

  2. Components: Avoid body check on focus return unmount 

    Existed prior to refactoring to track events (#2321, #931).

Causes conflict where intentional tabs away from the mounted element would revert focus back to the element (twice tab to dismiss a tooltip'd element)
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    ed28f60 View commit details
    Browse the repository at this point in the history

  3. Components: Refactor Popover to focus by presence of tabbable

    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    b79a1eb View commit details
    Browse the repository at this point in the history

  4. Components: Add FocusOutside convenience component 

    See included README.md
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    cb13136 View commit details
    Browse the repository at this point in the history

  5. Components: Open Popover to first tabbable by keydown

    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    eb9db40 View commit details
    Browse the repository at this point in the history

  6. Components: Stop propagation on handled dropdown focus first 

    Other handlers may conflict with intended behavior, e.g. pressing arrow down after clicking block settings menu, where WritingFlow will try to infer arrow down as transitioning into block content.
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    727b734 View commit details
    Browse the repository at this point in the history

  7. Components: Prevent scroll on dropdown arrow press

    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    86faea2 View commit details
    Browse the repository at this point in the history

  8. Components: Remove redundant DropdownMenu logic 

    Built into Dropdown.
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    85ecd98 View commit details
    Browse the repository at this point in the history

  9. Components: Assign More Menu as menu role 

    NVDA screen reader skips event handlers except for specific roles
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    84e78a3 View commit details
    Browse the repository at this point in the history

  10. Revert "Components: Assign More Menu as menu role" 

    This reverts commit bbd56ff.
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    5ff7509 View commit details
    Browse the repository at this point in the history

  11. Components: Focus popover content wrapper on mount

    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    d0d8d6f View commit details
    Browse the repository at this point in the history

  12. Components: Don't transition focus if already focused within

    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    237429a View commit details
    Browse the repository at this point in the history

  13. Tests: Await toolbar setting set before toolbar test proceeds 

    Otherwise race conditions where toolbar setting change occurs simultaneous to remainder of test actions.
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    c95e2e1 View commit details
    Browse the repository at this point in the history

  14. Components: Always focus content wrapper 

    While we need to exclude Tooltips from this behavior, which ought to otherwise described by appropriate ARIA attributes, we need to support screen readers which will navigate non-focusable content.
    @aduth
    aduth committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    f2a2f1b View commit details
    Browse the repository at this point in the history