Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken list markup in navigation block when 3rd party blocks are used as decendants of navigation block #55551

Merged
merged 17 commits into from
Feb 8, 2024
Merged

Fix broken list markup in navigation block when 3rd party blocks are used as decendants of navigation block #55551

merged 17 commits into from
Feb 8, 2024
+117 −16

Commits on Feb 8, 2024

  1. fix use tag processor instead of hardcoded list of list item blocks i… 

    …n navigation block render callback

fix phpcs issue
    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6a36979 View commit details
    Browse the repository at this point in the history

  2. fix whitespace issue

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d8af377 View commit details
    Browse the repository at this point in the history

  3. fix apply patch for using tag processor instead of hardcoded list of … 

    …blocks to moved WP_Navigation_Block_Renderer class
    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b542e41 View commit details
    Browse the repository at this point in the history

  4. fix whitespace issue

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    66316ea View commit details
    Browse the repository at this point in the history

  5. fix add back has_submenus propertry

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f66a731 View commit details
    Browse the repository at this point in the history

  6. add filter to allow modification of which blocks get wrapped in a lis… 

    …t item
    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    da242ab View commit details
    Browse the repository at this point in the history

  7. add test case for needs list item wrapper filter

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    222e409 View commit details
    Browse the repository at this point in the history

  8. fix whitespace

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    e3511a5 View commit details
    Browse the repository at this point in the history

  9. Update filter docblock

    @getdave
    getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    1334a33 View commit details
    Browse the repository at this point in the history

  10. fix update test cases to be more clear

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6eb26ae View commit details
    Browse the repository at this point in the history

  11. fix rename filter for greater clarity

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9da5725 View commit details
    Browse the repository at this point in the history

  12. fix whitespace and grammar

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f43e902 View commit details
    Browse the repository at this point in the history

  13. fix whitespace

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    49e5ae9 View commit details
    Browse the repository at this point in the history

  14. fix markup of demo block

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5326aec View commit details
    Browse the repository at this point in the history

  15. fix test case

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    bc34eca View commit details
    Browse the repository at this point in the history

  16. fix test case

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    74e45c2 View commit details
    Browse the repository at this point in the history

  17. fix rename the new filter to block_core_navigation_listable_blocks

    @fabiankaegy @getdave
    fabiankaegy authored and getdave committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    222ef57 View commit details
    Browse the repository at this point in the history