Reset page after changing pattern filters or search value #54774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: +50 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Thanks for the rapid pagination fixes here @kevin940726
This tests well for me and I appreciate the keyboard-focused test instructions 👍
✅ Pattern pagination in the inserter is correctly reset when switching filters
✅ Pagination in pattern explorer is correctly reset on search term change
kevin940726
deleted the
fix/reset-page-after-swtching-pattern-filters
branch
mikachan
pushed a commit
that referenced
this pull request
Sep 25, 2023
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 7936d79 |
mikachan
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reset the page in the patterns inserter and explorer when changing the filters or the search value.
Why?
It could result in no patterns when filtering or searching while there are results.
How?
Calling
changePage( 1 )at the right time and place.Testing Instructions for Keyboard
Screenshots or screencast
Kapture.2023-09-25.at.14.14.21.mp4