[RNMobile] Upgrade compileSdkVersion to 34 (Android)
#54437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Build Tooling
3 tasks
thomashorta
approved these changes
Sep 14, 2023
12 tasks
fluiddot
commented
Sep 14, 2023
| @@ -11,7 +11,7 @@ buildscript { | |||
| espressoVersion = '3.0.1' | |||
|
|
|||
| // libs | |||
| aztecVersion = 'v1.6.4' | |||
| aztecVersion = 'v1.8.0' | |||
There was a problem hiding this comment.
The Aztec library has been updated to incorporate wordpress-mobile/AztecEditor-Android#1059.
There was a problem hiding this comment.
I'll do the writing flow tests in wordpress-mobile/gutenberg-mobile#6196 (comment) to double check it's working as expected.
cc @thomashorta @ParaskP7 in case you have concerns/feedback about following the above approach. |
geriux
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
compileSdkVersionto 34 (Android) wordpress-mobile/gutenberg-mobile#6196compileSdkVersionto 34 wordpress-mobile/WordPress-Android#19182What?
Upgrades the
compileSdkVersionto 34 as part of the support for Android 14.Why?
Closes wordpress-mobile/gutenberg-mobile#6142.
How?
Updates the value in all references of
compileSdkVersion:react-native-aztecreact-native-bridgereact-native-editorBump
AztecEditor-Androidversion to1.8.0, which also uses version 34 ofcompileSdkVersion.I assume that since we are only updating the
compileSdkVersionand nottargetSdkVersion, it's safe to leave them with an older version. But once we fully upgrade to Android 14, we'd need to update them.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A