Bundle the block selection clearer hook into the BlockCanvas component #54209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
noisysocks,
draganescu,
talldan and
adamziel
as code owners
|
Size Change: -44 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ff56869. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6096684538
|
jorgefilipecosta
approved these changes
Sep 6, 2023
youknowriad
force-pushed
the
update/bundle-block-selection-clearer
branch
from
7e0a523
to
ff56869
Compare
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #53874
What and why?
Gutenberg can be used as a platform/framework to build block editors. Mainly thanks to the @wordpress/block-editor package. That said, the experience today is not as straightforward as it can be. There can be a lot of small gotchas and hacks you need to do in order to achieve the desired result. One of these small things is that clicking the block canvas outside any block should clear the block selection.
This PR updates the BlockCanvas component to enable this behavior by default.
Testing Instructions
1- Check on the side of the selected block (or before the post title) to clear the block selection.