Make order of pinned items consistent #53908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +442 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
draganescu
added
the
[Type] Bug
|
Flaky tests detected in 868d6d2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6119819128
|
|
This change does not achieve much as the rendering of the pinned items is extremely variable: 
|
scruffian
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
I think that having the site and post editor settings in the same place makes sense.
The rendering of fills is non-deterministic, and that seems like a very tricky to problem to solve: #15641, but that shouldn't stop this.
draganescu
force-pushed
the
fix/pinned-items-ordering
branch
from
a7698fd
to
5b52ea4
Compare
|
I am exploringt this solution:
|
draganescu
force-pushed
the
fix/pinned-items-ordering
branch
5 times, most recently
from
5eb267a
to
2c77bac
Compare
draganescu
force-pushed
the
fix/pinned-items-ordering
branch
from
685a0f0
to
868d6d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #53899
Why
Because #53412 surfaced an inconsistency in the way pinned items are rendered by plugins in the editor header.
How
Updates the post editor to render the editor pinned items (the edit post sidebar with document and block tabs) last - like the site editor renders the same thing last.