-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Release v1.100.2 #53293
Merged
Merged
Mobile Release v1.100.2 #53293
Commits on Jul 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d3e7f7d - Browse repository at this point
Copy the full SHA d3e7f7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce120b - Browse repository at this point
Copy the full SHA 2ce120bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6abc32d - Browse repository at this point
Copy the full SHA 6abc32dView commit details
Commits on Aug 3, 2023
-
Release script: Update react-native-editor version to 1.100.2
Gerardo committedAug 3, 2023 Configuration menu - View commit details
-
Copy full SHA for da19381 - Browse repository at this point
Copy the full SHA da19381View commit details -
Release script: Update with changes from 'npm run core preios'
Gerardo committedAug 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 4d6d5f2 - Browse repository at this point
Copy the full SHA 4d6d5f2View commit details -
Mobile - Fix iOS Focus loop for RichText components (#53217)
* Mobile - Update changelog * fix: Avoid iOS block appender focus loop The focus callback triggered by Aztec-based programmatic focus events can result in focus loops between rich text elements. Android: This intentional no-op function prevents focus loops originating when the native Aztec module programmatically focuses the instance. The no-op is explicitly passed as an `onFocus` prop to avoid future prop spreading from inadvertently introducing focus loops. The user-facing focus of the element is handled by `onPress` instead. See: wordpress-mobile/gutenberg-mobile#302 iOS: Programmatic focus from the native Aztec module is required to ensure the React-based `TextStateInput` ref is properly set when focus is *returned* to an instance, e.g. dismissing a bottom sheet. If the ref is not updated, attempts to dismiss the keyboard via the `ToolbarButton` will fail. See: wordpress-mobile/gutenberg-mobile#702 The Android keyboard is, likely erroneously, already dismissed in the contexts where programmatic focus may be required on iOS. - #28748 - #29048 - wordpress-mobile/WordPress-Android#16167 Programmatic swapping focus from element to another often leads to focus loops, only delegate the programmatic focus if there are no elements focused. See: wordpress-mobile/WordPress-iOS#18783 * fix: Programmatic Aztec input focus only updates internal ref Programmatically swapping input focus creates an infinite loop if the user taps a different input in between the programmatic focus and the resulting update to the React Native TextInputState focused element ref. To mitigate this, the Aztec now updates the focused element ref, but does not call the native focus methods. See: wordpress-mobile/WordPress-iOS#18783 * Mobile - AztecView - Check for isFocused before forcing the focus * Mobile - DefaultBlockAppender and BlockList Footer placeholders - Removes inline functions and other minor code style changes * Mobile - AztecView - Trigger _onFocus within _onAztecFocus to prevent having a RichText component focused while another block is selected --------- Co-authored-by: David Calhoun <438664+dcalhoun@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2b215b1 - Browse repository at this point
Copy the full SHA 2b215b1View commit details -
Merge branch 'trunk' into rnmobile/release_1.100.2
# Conflicts: # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
Gerardo committedAug 3, 2023 Configuration menu - View commit details
-
Copy full SHA for 89d8227 - Browse repository at this point
Copy the full SHA 89d8227View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.