Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Release v1.100.2 #53293

Merged
merged 7 commits into from
Aug 3, 2023
Merged

Mobile Release v1.100.2 #53293

merged 7 commits into from
Aug 3, 2023

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    d3e7f7d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ce120b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6abc32d View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    da19381 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d6d5f2 View commit details
    Browse the repository at this point in the history
  3. Mobile - Fix iOS Focus loop for RichText components (#53217)

    * Mobile - Update changelog
    
    * fix: Avoid iOS block appender focus loop
    
    The focus callback triggered by Aztec-based programmatic focus events
    can result in focus loops between rich text elements.
    
    Android: This intentional no-op function prevents focus loops
    originating when the native Aztec module programmatically focuses the
    instance. The no-op is explicitly passed as an `onFocus` prop to avoid
    future prop spreading from inadvertently introducing focus loops. The
    user-facing focus of the element is handled by `onPress` instead.
    
    See: wordpress-mobile/gutenberg-mobile#302
    
    iOS: Programmatic focus from the native Aztec module is required to
    ensure the React-based `TextStateInput` ref is properly set when focus
    is *returned* to an instance, e.g. dismissing a bottom sheet. If the ref
    is not updated, attempts to dismiss the keyboard via the `ToolbarButton`
    will fail.
    
    See: wordpress-mobile/gutenberg-mobile#702
    
    The Android keyboard is, likely erroneously, already dismissed in the
    contexts where programmatic focus may be required on iOS.
    
    - #28748
    - #29048
    - wordpress-mobile/WordPress-Android#16167
    
    Programmatic swapping focus from element to another often leads to focus
    loops, only delegate the programmatic focus if there are no elements
    focused.
    
    See: wordpress-mobile/WordPress-iOS#18783
    
    * fix: Programmatic Aztec input focus only updates internal ref
    
    Programmatically swapping input focus creates an infinite loop if the
    user taps a different input in between the programmatic focus and
    the resulting update to the React Native TextInputState focused element
    ref. To mitigate this, the Aztec now updates the focused element ref,
    but does not call the native focus methods.
    
    See: wordpress-mobile/WordPress-iOS#18783
    
    * Mobile - AztecView - Check for isFocused before forcing the focus
    
    * Mobile - DefaultBlockAppender and BlockList Footer placeholders - Removes inline functions and other minor code style changes
    
    * Mobile - AztecView - Trigger _onFocus within _onAztecFocus to prevent having a RichText component focused while another block is selected
    
    ---------
    
    Co-authored-by: David Calhoun <438664+dcalhoun@users.noreply.github.com>
    Gerardo Pacheco and dcalhoun committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    2b215b1 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'trunk' into rnmobile/release_1.100.2

    # Conflicts:
    #	packages/react-native-aztec/package.json
    #	packages/react-native-bridge/package.json
    #	packages/react-native-editor/CHANGELOG.md
    #	packages/react-native-editor/ios/Podfile.lock
    #	packages/react-native-editor/package.json
    Gerardo committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    89d8227 View commit details
    Browse the repository at this point in the history