Migrate 'Block variations' e2e tests to Playwright #53266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
commented
Aug 2, 2023
| ).toBeDefined(); | ||
| } ); | ||
|
|
||
| test( 'Insert the Large Quote block variation with slash command', async () => { |
There was a problem hiding this comment.
I removed this test during migration. The previous test case uses the slash command, so we already cover this case.
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
Mamaduka
requested review from
jeryj and
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
|
Flaky tests detected in ce4358b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5737636437
|
|
@kevin940726, it would be nice to land this refactoring as the test in question fails quite often. |
kevin940726
approved these changes
Aug 4, 2023
| await expect( | ||
| editor.canvas | ||
| .getByRole( 'document', { name: 'Block: Columns' } ) | ||
| .getByRole( 'document' ) |
There was a problem hiding this comment.
Should we add { name: /Block: Column \([1-4] of 4\)/ } here?
There was a problem hiding this comment.
I think it's okay to have this broad locator. We just want to check the number of inner blocks.
| ).toHaveCount( 4 ); | ||
| } ); | ||
|
|
||
| // Tests the `useBlockDisplayInformation` hook. |
There was a problem hiding this comment.
Do we want to group these tests with describe as the original code did?
There was a problem hiding this comment.
Not sure. They fit well without the grouping as well and require no special setup.
| // @see @wordpres/block-editor/src/components/use-block-display-information (`useBlockDisplayInformation` hook). | ||
| describe( 'testing block display information with matching variations', () => { | ||
| beforeEach( async () => { | ||
| await togglePreferencesOption( |
There was a problem hiding this comment.
Sorry if I missed it but I didn't see this in the migrated code. Do we not need this anymore? What was it for?
There was a problem hiding this comment.
The breadcrumbs are enabled by default. If any other test disables it, I think it should enable it back after the tests.
There was a problem hiding this comment.
Cool 👍 Thanks for the explanation!
|
Thanks for the review, @kevin940726! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Closes #47057.
PR migrates 'Block variations' e2e tests to Playwright.
Why?
The
Pick the additional variation in the inserted Columns blocktest case failed at least 300 times since January. The number is based on flaky test issue edits. See #47057.Testing Instructions