Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Add 'Show template' toggle when editing pages #52674

Merged
merged 16 commits into from
Sep 20, 2023
Merged

Site Editor: Add 'Show template' toggle when editing pages #52674

merged 16 commits into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. Site Editor: First pass at adding a Show Template toggle when editing… 

    … pages
    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    06dbb44 View commit details
    Browse the repository at this point in the history

  2. Bit of clean up

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8562bdc View commit details
    Browse the repository at this point in the history

  3. Use a toggle in sidebar

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e03e995 View commit details
    Browse the repository at this point in the history

  4. Make toggling 'Show template' on/off faster

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    50f19cf View commit details
    Browse the repository at this point in the history

  5. Use blocks in same order as template

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8d958ce View commit details
    Browse the repository at this point in the history

  6. Tidy up code

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    663c2ee View commit details
    Browse the repository at this point in the history

  7. Add unit tests

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    068ae1d View commit details
    Browse the repository at this point in the history

  8. Add doc comment

    @noisysocks @ramonjd
    noisysocks authored and ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    782d4f1 View commit details
    Browse the repository at this point in the history

  9. Formatting 

    Remove unused component import
Doc update
    @ramonjd
    ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    d1308a1 View commit details
    Browse the repository at this point in the history

  10. With icon and updated copy

    @ramonjd
    ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    fcd7d64 View commit details
    Browse the repository at this point in the history

  11. Use only the check icon and set min width of dropdown to minimize the… 

    … effect of the dropdown width toggling between narrow and wide
    @ramonjd
    ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    93aef3e View commit details
    Browse the repository at this point in the history

  12. This commit tries to get around a peculiarity of __experimentalGetGlo… 

    …balBlocksByName, which doesn't seem to be able to find the post-content block in a new block tree (if it even exists in state).

We're sidestepping the issue, but with fewer selectors, so overall hopefully it's more sustainable.
    @ramonjd
    ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    9da8354 View commit details
    Browse the repository at this point in the history

  13. Removing the filter iteration layer and adding it to the flattenBlock… 

    … helper function

Checking for disallowed blocks as well, e.g., core/query
    @ramonjd
    ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a20ef59 View commit details
    Browse the repository at this point in the history

  14. Extract usePageContentBlocks and write basic tests 

    Moving PAGE_CONTENT_BLOCK_TYPES to utils/constants and creating a map
    @ramonjd
    ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    a384980 View commit details
    Browse the repository at this point in the history

  15. Updates selectors to include canvas mode so we can show any hidden te… 

    …mplates in focus mode
    @ramonjd
    ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    30af53c View commit details
    Browse the repository at this point in the history

  16. Moving getPageContentFocusType and setPageContentFocusType selector/a… 

    …ction to locked, private methods

In the use-page-content-blocks.js test, add innerblocks to the query test block
    @ramonjd
    ramonjd committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0724b6d View commit details
    Browse the repository at this point in the history