fix: Paragraphs inherit parent text alignment #52293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Paragraph `align` attribute was renamed to `textAlign`. Hence, these changes adapt the block list to pass the relevant attribute to its child blocks.
dcalhoun
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
Flaky tests detected in cf0d6e3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5458462045
|
dcalhoun
removed
the
Mobile App - Automation
geriux
approved these changes
Jul 7, 2023
dcalhoun
merged commit f2f96c5
into
update/rename-align-attribute
51 of 52 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix Paragraphs inheriting text alignment from parent blocks.
Why?
The absence of this ability is a regression from renaming the Paragraph block's
alignattribute totextAlignin #42960. This ability was first added in#40439 (comment).
How?
The block list item now passes the value of the parent's
textAlignattributerather than
alignattribute.Testing Instructions
block.
text alignment.
Testing Instructions for Keyboard
n/a
Screenshots or screencast
See #42960 (comment).