Blocks: Support reusable nested blocks (reusable blocks refactor) #5228
Commits on Mar 14, 2018
-
Revert "Blocks: Disable Convert to Reusable for nested blocks"
This reverts commit 8872058.
-
-
Blocks: Avoid dismissing editable controls
In nested context, block selection changes from reusable block to the inner block being edited, but we want to keep the UI shown
-
-
Block List: Hide disabled default block appender
e.g. within Disabled component, e.g. within reusable nested block
-
-
Block List: Inject inner block list creator as function
Generate BlockList from block's own utils, which has advantage of: - Not having circular dependency from blocks to editor - Respecting block menu and contextual toolbar props
-
-
-
-
-
Update getInserterItems to respect new reusable block data layout
Makes `getInserterItems` and `getFrecentInserterItems` respect that reusable blocks now point to a block that is elsewhere in the editor state. This makes reusable blocks again appear in the inserter.
-
Provide createInnerBlockList context in BlockPreview
Allow reusable nested blocks to be previewed in the inserter by having BlockPreview inject a createInnerBlockList function via context.
-
Fix flash of 'Not found' error message when fetching a reusable block
Re-order the FETCH_REUSABLE_BLOCKS effect so that the reusable block is added to the store before it is marked as no longer being fetched. This prevents core/block from briefly flashing the 'Not found' error message in between dispatches.
-
When converting reusable -> regular, replace the block with a copy
Making a copy of the referenced block prevents the regular block from being removed should the reuasble block be later deleted.
-
Avoid iterating through reusable blocks twice
Use _.map to avoid iterating through the reusable blocks twice in `getReusableBlocks`.
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.