Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LinkControl Edit UI #51712

Merged
merged 33 commits into from
Jun 26, 2023
Merged

Improve LinkControl Edit UI #51712

merged 33 commits into from
Jun 26, 2023

Commits on Jun 26, 2023

  1. Move text above link

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    bd8b3fc View commit details
    Browse the repository at this point in the history

  2. Change "URL" label to "Link"

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e79a678 View commit details
    Browse the repository at this point in the history

  3. Style tweaks

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f76f8a9 View commit details
    Browse the repository at this point in the history

  4. Add chevron based advanced settings button

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c0552f5 View commit details
    Browse the repository at this point in the history

  5. Adapt logic for rendering actions and settings

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    87b47c5 View commit details
    Browse the repository at this point in the history

  6. Tweaks

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    671914b View commit details
    Browse the repository at this point in the history

  7. Add proper i18n 

    Co-authored-by: Ben Dwyer <ben@scruffian.com>
    @richtabor @scruffian @getdave
    2 people authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    11c0998 View commit details
    Browse the repository at this point in the history

  8. Remove commented out style 

    Co-authored-by: Ben Dwyer <ben@scruffian.com>
    @richtabor @scruffian @getdave
    2 people authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ada13cb View commit details
    Browse the repository at this point in the history

  9. Use $button-size-next-default-40px

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    37dee3e View commit details
    Browse the repository at this point in the history

  10. Add showSettings, combine with new logic

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    6c550c4 View commit details
    Browse the repository at this point in the history

  11. Add additional translation context to advanced

    @richtabor @getdave
    richtabor authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    b277518 View commit details
    Browse the repository at this point in the history

  12. Update toggle drawer name in tests

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    eec4bef View commit details
    Browse the repository at this point in the history

  13. Standardise query for settings toggle

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    62ef07b View commit details
    Browse the repository at this point in the history

  14. Update test to check for absence of cancel button during link creation

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5ab42eb View commit details
    Browse the repository at this point in the history

  15. Fix cancellation tests

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8c03ac1 View commit details
    Browse the repository at this point in the history

  16. Ensure label is always “Link” but remains hidden when it’s the only v… 

    …isible control
    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    1ebaba2 View commit details
    Browse the repository at this point in the history

  17. Update tests to look for “Link” instead of “URL” name for input

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f6619c3 View commit details
    Browse the repository at this point in the history

  18. Update empty value UI tests to only run for editing as opposed to cre… 

    …ating links
    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c12e3ce View commit details
    Browse the repository at this point in the history

  19. Fix e2e test tabbing order

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    3cf9343 View commit details
    Browse the repository at this point in the history

  20. Use updated terms

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f6a7c1e View commit details
    Browse the repository at this point in the history

  21. Select settings toggle by text not aria label

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e1d1305 View commit details
    Browse the repository at this point in the history

  22. Fix another tabbing order bug

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    fac61cc View commit details
    Browse the repository at this point in the history

  23. Fix one more tabbing issue in e2e tests

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c1297e3 View commit details
    Browse the repository at this point in the history

  24. Fix final tab ordering e2e test

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8c9f1a8 View commit details
    Browse the repository at this point in the history

  25. Decouple conditions for showing action buttons from settings 

    Settings may not be provided but action buttons are always needed
    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    1bc002e View commit details
    Browse the repository at this point in the history

  26. Tweak styling to account for action buttons when there are no setting… 

    …s provided
    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    a25340b View commit details
    Browse the repository at this point in the history

  27. Fix test

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    531ad75 View commit details
    Browse the repository at this point in the history

  28. Fix e2e test

    @scruffian @getdave
    scruffian authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    b3cb16f View commit details
    Browse the repository at this point in the history

  29. Update name of the combobox

    @scruffian @getdave
    scruffian authored and getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    86898b2 View commit details
    Browse the repository at this point in the history

  30. Fix test expecting Submit button on creation

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e1d499b View commit details
    Browse the repository at this point in the history

  31. Fix test by testing under edit rather than creation conditions

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ffb0435 View commit details
    Browse the repository at this point in the history

  32. Rename URL to Link and avoid triggering command centre

    @getdave
    getdave committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    a78ba7e View commit details
    Browse the repository at this point in the history

  33. move test earlier

    @scruffian
    scruffian committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    389cb5a View commit details
    Browse the repository at this point in the history