-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav block: link text color inheritance fixes and tests #51710
Commits on Jul 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d7587f4 - Browse repository at this point
Copy the full SHA d7587f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d1c89d - Browse repository at this point
Copy the full SHA 7d1c89dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fcc62c - Browse repository at this point
Copy the full SHA 4fcc62cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 830a356 - Browse repository at this point
Copy the full SHA 830a356View commit details -
Configuration menu - View commit details
-
Copy full SHA for 489f2a4 - Browse repository at this point
Copy the full SHA 489f2a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e419f4f - Browse repository at this point
Copy the full SHA e419f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 798a886 - Browse repository at this point
Copy the full SHA 798a886View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f5e5f2 - Browse repository at this point
Copy the full SHA 1f5e5f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b65241 - Browse repository at this point
Copy the full SHA 1b65241View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5c6778 - Browse repository at this point
Copy the full SHA c5c6778View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c772ab - Browse repository at this point
Copy the full SHA 1c772abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 307123f - Browse repository at this point
Copy the full SHA 307123fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 186338a - Browse repository at this point
Copy the full SHA 186338aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f1fd9e - Browse repository at this point
Copy the full SHA 1f1fd9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce5a726 - Browse repository at this point
Copy the full SHA ce5a726View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c8461 - Browse repository at this point
Copy the full SHA 53c8461View commit details -
Configuration menu - View commit details
-
Copy full SHA for d737271 - Browse repository at this point
Copy the full SHA d737271View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb194a1 - Browse repository at this point
Copy the full SHA eb194a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f50ed5 - Browse repository at this point
Copy the full SHA 5f50ed5View commit details -
Configuration menu - View commit details
-
Copy full SHA for eec98d1 - Browse repository at this point
Copy the full SHA eec98d1View commit details -
Add test coverage for selecting group text color that should be inher…
…ited by all links This test is currently failing. TDD.
Configuration menu - View commit details
-
Copy full SHA for 77d3df0 - Browse repository at this point
Copy the full SHA 77d3df0View commit details
Commits on Jul 7, 2023
-
Fix incorrect selector structure.
The &:where(.wp-block-navigation-item a) rule would never apply, as .wp-block-navigation__responsive-container would never also have a .wp-block-navigation-item class on it. Adding the space allows it to apply the inherit rule to the a tag.
Configuration menu - View commit details
-
Copy full SHA for 7d90814 - Browse repository at this point
Copy the full SHA 7d90814View commit details -
Configuration menu - View commit details
-
Copy full SHA for a436cd3 - Browse repository at this point
Copy the full SHA a436cd3View commit details -
Big refactor of navigation color tests
* Changed link names from non-descriptive firstLink, secondLink, and thirdLink to clearer names: customLink, submenuLink, and pageLink. * Combined some repeated operations such as openEditorOverlay, openFrontendOverlay, and resetGlobalStyles * Added ColorControl for keeping track of all the link selectors
Configuration menu - View commit details
-
Copy full SHA for ce82292 - Browse repository at this point
Copy the full SHA ce82292View commit details -
Revert link color settings changing the navigation link colors
The trunk behavior is to have text color global styles change the navigation color styles, while the global link color styles do not change the navigation colors. Also updated the tests to not have any of those color changes impact the submenus.
Configuration menu - View commit details
-
Copy full SHA for 4541b41 - Browse repository at this point
Copy the full SHA 4541b41View commit details
Commits on Jul 11, 2023
-
Large refactor of navigation color tests
It was getting difficult to work within several very long tests with a lot of shared code, so I refactored into shared pieces that would make writing the tests easier while keeping debugging easy as well. Also, one large change was to remove the reliance on global styles since resetting the global styles after a failed test was proving very difficult, and we don't need to use global styles since we can rely on creating a group instead. By wrapping a group on the navigation block we can test the same thing while not needing to deal with global styles.
Configuration menu - View commit details
-
Copy full SHA for 65ea6ca - Browse repository at this point
Copy the full SHA 65ea6caView commit details -
Add test for navigation background colors
Also added closing the sidebar in the tests so we don't accidentally grab the links from the sidebar when the navigation block has the sidebar menu open with the same link text.
Configuration menu - View commit details
-
Copy full SHA for 0f6473c - Browse repository at this point
Copy the full SHA 0f6473cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42086c5 - Browse repository at this point
Copy the full SHA 42086c5View commit details -
Only set default navigation submenu and overlay text colors if no nav…
…igation text color is selected
Configuration menu - View commit details
-
Copy full SHA for 1a3c0b3 - Browse repository at this point
Copy the full SHA 1a3c0b3View commit details
Commits on Jul 12, 2023
-
Have li navigation items inherit background color so it can be inheri…
…ted by the submenu background
Configuration menu - View commit details
-
Copy full SHA for e7c72ed - Browse repository at this point
Copy the full SHA e7c72edView commit details -
Change how to test editor mobile overlay colors
The tests were a little flaky when tryingn to click the button to open the mobile view since the animation from desktop to mobile in the editor took some time, and the test was trying to click the open menu button before it was able to be clicked. This updates the test to use the navigation settings itself, which doesn't have an animation, so it should be more reliable.
Configuration menu - View commit details
-
Copy full SHA for 8f27fd3 - Browse repository at this point
Copy the full SHA 8f27fd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c693611 - Browse repository at this point
Copy the full SHA c693611View commit details
Commits on Jul 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for db21c63 - Browse repository at this point
Copy the full SHA db21c63View commit details -
Configuration menu - View commit details
-
Copy full SHA for ada037c - Browse repository at this point
Copy the full SHA ada037cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8786a7c - Browse repository at this point
Copy the full SHA 8786a7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3131a7d - Browse repository at this point
Copy the full SHA 3131a7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 680072d - Browse repository at this point
Copy the full SHA 680072dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 716d992 - Browse repository at this point
Copy the full SHA 716d992View commit details -
Configuration menu - View commit details
-
Copy full SHA for e726585 - Browse repository at this point
Copy the full SHA e726585View commit details -
Configuration menu - View commit details
-
Copy full SHA for e49f423 - Browse repository at this point
Copy the full SHA e49f423View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffc6806 - Browse repository at this point
Copy the full SHA ffc6806View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57fe3b1 - Browse repository at this point
Copy the full SHA 57fe3b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6988f59 - Browse repository at this point
Copy the full SHA 6988f59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bdd9aa - Browse repository at this point
Copy the full SHA 1bdd9aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05927a0 - Browse repository at this point
Copy the full SHA 05927a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50113d2 - Browse repository at this point
Copy the full SHA 50113d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c4d8d - Browse repository at this point
Copy the full SHA 53c4d8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5e10fd - Browse repository at this point
Copy the full SHA c5e10fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83d168c - Browse repository at this point
Copy the full SHA 83d168cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a80a1b - Browse repository at this point
Copy the full SHA 6a80a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b3710d - Browse repository at this point
Copy the full SHA 6b3710dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2115868 - Browse repository at this point
Copy the full SHA 2115868View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1a9724 - Browse repository at this point
Copy the full SHA b1a9724View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92f289d - Browse repository at this point
Copy the full SHA 92f289dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca77108 - Browse repository at this point
Copy the full SHA ca77108View commit details -
Configuration menu - View commit details
-
Copy full SHA for 299c028 - Browse repository at this point
Copy the full SHA 299c028View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a261f7 - Browse repository at this point
Copy the full SHA 3a261f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c111b9 - Browse repository at this point
Copy the full SHA 4c111b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27a1694 - Browse repository at this point
Copy the full SHA 27a1694View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff5be80 - Browse repository at this point
Copy the full SHA ff5be80View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1e0f3d - Browse repository at this point
Copy the full SHA f1e0f3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f10b86a - Browse repository at this point
Copy the full SHA f10b86aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfb8266 - Browse repository at this point
Copy the full SHA cfb8266View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2aa309d - Browse repository at this point
Copy the full SHA 2aa309dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a0cc47 - Browse repository at this point
Copy the full SHA 6a0cc47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b66e92 - Browse repository at this point
Copy the full SHA 1b66e92View commit details