Remove experimental flag from navigation and file blocks to use the Interactivity API (as private) #51266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
the
[Feature] Interactivity API
SantosGuillamot
requested review from
spacedmonkey,
tellthemachines and
ajitbohra
as code owners
|
Size Change: -3.42 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b318b9f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5191523823
|
luisherranz
requested changes
Jun 6, 2023
There was a problem hiding this comment.
I've detected a couple of problems related to the files and directives:
- When there are no submenus, we should ignore
openSubmenusOnClickandshowSubmenuIconand treat them as if they werefalse. - When
overlayMenuisfalse,openSubmenusOnClickisfalsebutshowSubmenuIconistrue, the directives are not being injected into thenav. I don't know why. Looking at the code I couldn't spot the problem.
https://www.loom.com/share/2bd82cfd63c3484e92895670be31c57e
Is there an easy way to know if there are any submenus?
|
Thanks a lot for the in-depth review and the video 🙂
Oh, I think it is because of this conditional. I guess this could be solved adding the directives to that element or adding
First thing that comes to my mind is using the Tag Processor, checking if there is an element with the |
|
I just updated the code to solve the issues you mentioned. Let me know if that's okay 🙂 |
luisherranz
approved these changes
Jun 6, 2023
luisherranz
approved these changes
Jun 6, 2023
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
luisherranz
deleted the
update/remove-experimental-flag-navigation-and-file-blocks
branch
ramonjd
added
Needs PHP backport
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…nteractivity API (as private) (WordPress#51266) * Remove experimental flag from file block * Remove experimental flag from navigation block * Fix ESC triggering closeMenu more than expected * Update experiments page label * Don't send JS files when there are no submenus * Add `data-wp-interactive` to submenus * Change has_submenu conditional to include subpages * Update experimental label Co-authored-by: Luis Herranz <luisherranz@gmail.com> * Use Tag Processor instead of `strpos` * Format `index.php` file --------- Co-authored-by: Luis Herranz <luisherranz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I opened a while ago a similar pull request to remove the Interactivity API experimental flag completely. However, as the navigation and the file blocks have already been experimental for a while, and they are not adding new functionalities, I believe we can remove the experimental flag from them while keeping it for other blocks using the Interactivity API.
Keep in mind that it doesn't mean exposing the Interactivity API. It remains private only available for these blocks. This means that external blocks/plugins cannot use it, and we can keep experimenting and iterating.
Why?
At this moment, users can only test the navigation and the file blocks using the Interactivity API if they activate the Experimental flag on the Gutenberg Experiments page.
How?
These are the steps I took:
script-loader.phpfrom theload.phpfile.viewScriptfield of theblock.jsonof the Navigation and File blocks to read the interactivity.js file.view.jsfiles.index.phpof the Image and File blocks.Apart from that, I fixed a small bug where the
closeMenufunction was being triggered more than expected when pressing the ESC key when the menu was closed.Testing Instructions