Global Styles: Enable deep linking to the selected block only in the Blocks screen
#50708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: -4.79 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Maybe we should only enable deep linking when a user is already on the "Block" screen? Currently, if changing the Layout setting and accidentally change the block selection, my settings view will change, and I must navigate back. cc @richtabor, @annezazu |
This is a good idea IMO and will be more resilient to issues like the one this PR is trying to fix. --cc @WordPress/gutenberg-design |
I like that, and it echoes some concerns that @beafialho expressed here: |
…e `Blocks` screen
Mamaduka
approved these changes
May 18, 2023
There was a problem hiding this comment.
Thank you, @ntsekouras!
The fix works as expected, and I like the new logic much better :)
Screencast
CleanShot.2023-05-18.at.14.47.57.mp4
ntsekouras
changed the title
Blocks screen
westonruter
added a commit
that referenced
this pull request
May 19, 2023
…dd/static-closures * 'trunk' of https://github.com/WordPress/gutenberg: (26 commits) Add transparent outline to input control BackdropUI focus style. (#50772) Added wrapper element for RichText in File block (#50607) Remove the experimental flag of the command center (#50781) Update the document title in the site editor to open the command center (#50369) Remove `unwrap` from transforms and add `ungroup` to more blocks (#50385) Add new experimental version of DropdownMenu (#49473) Force display of in custom css input boxes to LTR (#50768) Polish experimental navigation block (#50670) Support negation operator in selectors in the Interactivity API (#50732) Minor updates to theme.json schema pages (#50742) $revisions_controller is not used. Let's delete it. (#50763) Remove OffCanvasEditor (#50705) Mobile - E2E test - Update code to use the new navigateUp helper (#50736) Try: Smaller external link icon (#50728) Block Editor: Remove unused 'useIsDimensionsSupportValid' method (#50735) Fix flaky media inserter drag-and-dropping e2e test (#50740) docs: Fix change log typo (#50737) Edit Site: Fix `useEditedEntityRecord()` loading state (#50730) Fix labelling, description, and focus style of the block transform to pattern previews (#50577) Fix Global Styles sidebar block selection on zoom out mode (#50708) ...
cbravobernal
changed the title
Blocks screenBlocks screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #50613
In this PR deep linking to the block type panel, when selecting a block with Styles open was added.
This PR enables deep linking to the selected block only in the
Blocksscreen.Testing Instructions