Site editor: make sure only one template deleted snackbar displays at once #50625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
Size Change: +20 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 15, 2023
|
Sorry I didn't catch this before it merged. I don't think we need to limit the number of Snackbars to one which might be too few. The problem is when they build up and begin to obscure the sidebar. A limit of 3 might work a bit better. |
I think how we now have it with one snackbar per notice type makes sense, ie. one for reset, one for deletes, etc. As far as I know, the notices package currently has no option to specify a max number at a given time and I don't think it is worth adding this complexity to it unless we get extensive feedback from users that the single notice per type is not working for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make sure only one template deleted snackbar notice displays at a time.
Why?
Stacking multiple notices obscures the interface.
Fixes: #46901
How?
Gives the notice a unique id.
Testing Instructions
Add several custom template parts
In the manage all template parts screen use the overflow menu to delete each new template
Check that only one snackbar displays
Screenshots or screencast
Before:
more-snackbars-eaten-before.mp4
After:
more-snackbars-eaten.mp4