Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Strip comment demarcations in content filtering #5042

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 14, 2018

Related: #4591

This pull request seeks to naively search and replace static block comment demarcations after server-side replacement has been completed. #4591 had the effect of only omitting comment demarcations for dynamic blocks from front-end content display. After these changes, all block comments should be omitted.

Testing instructions:

Verify that when viewing a block post on the front-end, no comment demarcations are shown.

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Feb 14, 2018
@aduth aduth requested a review from mtias February 14, 2018 01:57
@aduth aduth added this to the 2.2 milestone Feb 14, 2018
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@aduth aduth merged commit 14df09b into master Feb 15, 2018
@aduth aduth deleted the update/strip-block-comments branch February 15, 2018 19:36
@aduth aduth mentioned this pull request Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants