Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fonts API] Relocate which fonts to print into wp_print_fonts() #50151

Merged
merged 7 commits into from
May 8, 2023

Commits on May 2, 2023

  1. Configuration menu
    Copy the full SHA
    0af2d56 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6147c9b View commit details
    Browse the repository at this point in the history
  3. Add tests

    hellofromtonya committed May 2, 2023
    Configuration menu
    Copy the full SHA
    6dd2c35 View commit details
    Browse the repository at this point in the history
  4. Assign registered to $handles.

    This simplifies the code as it removes the need to modify and then reset
    the `done` and `queue` properties.
    hellofromtonya committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a64362c View commit details
    Browse the repository at this point in the history
  5. Set $handles to true

    hellofromtonya committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d95eb1c View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Combine ifs into if/elseif + micro-optimization

    Combines the empty() and true checks into a if/elseif structure.
    
    For a tiny micro-optimization, wraps these checks within a not
    equal to `false`.
    
    Why?
    
    When using the default (i.e. on the front-end and with classic themes):
    
    * Skips running `empty()`.
    * Skips reassigning `false` to `$handle`.
    
    These skips gain a tiny tiny performance boost.
    hellofromtonya committed May 3, 2023
    Configuration menu
    Copy the full SHA
    fd7ce33 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Restore overwriting queue and done.

    Printing `$handles` does not work (for some reason that needs to be investigated further). Overwriting
    the queue and done properties does print and has been working since 6.2 alpha. This commit restores
    the overwriting properties approach.
    hellofromtonya committed May 8, 2023
    Configuration menu
    Copy the full SHA
    dfd8657 View commit details
    Browse the repository at this point in the history