-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CPT e2e tests to Playwright #50031
Conversation
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
} ); | ||
|
||
await parentPageLocator.click(); | ||
await page.getByRole( 'listbox' ).getByRole( 'option' ).first().click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test doesn't care which option we select; only that selection remains after reloading. The options are populated based on the post ID, so it's hard to provide them explicitly.
Flaky tests detected in 33823a6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4786131087
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thanks!
} ); | ||
|
||
await parentPageLocator.click(); | ||
await page.getByRole( 'listbox' ).getByRole( 'option' ).first().click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could we add some parent locator to make it a bit easier to read here? There could be multiple listboxs on the same page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
Closes #36939.
PR migrates flaky custom post-type e2e tests to Playwright.
Testing Instructions