Resolve improperly applied border radius when the core/social-link block is interacted with #49766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Bug
|
Size Change: +87 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bab2162. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4680677687
|
|
Thanks for the PR! This is a tricky one, though: it appears that the radius here is applied whenever a block is multi selected or highlighted (the latter is the case here), and I think I may be the offending actor causing this regression, as I wrote this code:
But as you can see, this code also causes the issue on the Site Logo when rounded:
Especially as we roll out the radius tool to more blocks, we might need to revisit that. This seems to need fixing at the block UI level, rather than the block itself. What do you think? I'll make a note to look at this when I get a moment, we might need to revert the part of my past refactor that changed this from being a pseudo element to being on the block itself. Additionally I think there's an implementation aspect to social links that was fundamentally wrong. It uses the Button component for each social link, which means we have to unset and override every inherited button style:
That should probably have been a HTML |
|
Closed in favor of #49864 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #48492.
Why?
Fixing the visual distortion that occurs when a core/social-link is moved.
How?
Tiny CSS fix.
Testing Instructions
Screenshots or screencast
Before:
CleanShot.2023-04-12.at.12.02.35.mp4
After:
CleanShot.2023-04-12.at.12.01.31.mp4