-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Hide redundant search icon on mobile safari. #49710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
A suggestion for improvement.
Mobile Web
Viewport sizes for mobile and tablet devices
[Block] Search
Affects the Search Block - used to display a search field
labels
Apr 11, 2023
Size Change: +85 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Flaky tests detected in b80dd77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4665546618
|
jasmussen
requested review from
a team,
ellatrix and
tellthemachines
and removed request for
a team
April 20, 2023 10:39
aristath
approved these changes
Apr 26, 2023
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Search
Affects the Search Block - used to display a search field
Mobile Web
Viewport sizes for mobile and tablet devices
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #48259.
Mobile Safari adds a search icon to an HTML5 search field by default, even if one is added manually by the Search block:
This PR removes that by setting the appearance to "initial":
Testing Instructions
If you have a physical iphone you can connect, test this branch in that, perhaps using gutenberg.run. Otherwise, you can test using the xcode iphone simulator.
Notably, there should be no regressions to the search block behavior elsewhere.