Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: RTL styles don't get added to the wp-reusable-blocks stylesheet #49632

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

aristath
Copy link
Member

@aristath aristath commented Apr 6, 2023

What?

When adding RTL data to the wp-reusable-blocks stylesheet, it's written as wp-reusable-block with the s at the end missing. As a result, no RTL styles get registered for that stylesheet.

@aristath aristath requested a review from Mamaduka April 6, 2023 07:38
@aristath aristath changed the title Typo: The stylesheet handle is defined as wp-reusable-blocks (plural) and not -block Bug: RTL styles don't get added to the wp-reusable-blocks stylesheet Apr 6, 2023
@aristath aristath added the [Type] Bug An existing feature does not function as intended label Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Flaky tests detected in 0a7d6e4.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4626591380
📝 Reported issues:

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, Ari!

@Mamaduka Mamaduka merged commit 833176a into trunk Apr 11, 2023
@Mamaduka Mamaduka deleted the fix/stylesheet-handle-typo branch April 11, 2023 07:23
@Mamaduka Mamaduka added the [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) label Apr 11, 2023
@github-actions github-actions bot added this to the Gutenberg 15.6 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants