Home Link Block: Remove leading spaces in class names #49397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Mar 28, 2023
|
|
||
| $wrapper_attributes = get_block_wrapper_attributes( | ||
| array( | ||
| 'class' => $css_classes, | ||
| 'class' => implode( ' ', $classes ), |
There was a problem hiding this comment.
The $class array will contain the color classes, font size classes, and wp-block-navigation-item as values, but trim() should not be necessary.
t-hamano
added
[Type] Code Quality
|
Flaky tests detected in a11beb0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4543557752
|
Mamaduka
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes leading spaces in the class name when the Home Link block is rendered as a
lielement in a navigation block.Testing Instructions
Before
After