Global Navigation: Fix to Page List #49037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -150 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Thanks for the PR! Here's a quick GIF showing this page list replacement:
It may be worth restating some of the context for the navigation section. It looks like it won't make it for 6.2, but it'll be useful for future reintroductions. The way I think about it is that the Site Editor is a high level, well, site editor. That means upon entering it, with the main navigation pieces on the left and the site preview on the right, it is laid out that way to indicate: you are seeing your whole site, not just one particular template. A Design → Navigation section should lean into this, as should a future Design → Styles section. It's the the idea that when you are editing your whole site, you are in this receded high level view, whereas the fullscreen view is a more in-depth view. In that light: locking the navigation section to showing a page list (i.e. all the pages and the basic structure of your site), can make sense. Every website has a "physical" structure. If a contact page is published, it exists on Another benefit of having a section such as this, is the content editing aspect. This is a major motivation for the inclusion of the section, making the site editor about truly editing your site, not just templates. As is, this PR accomplishes that. (The locks would be good to hide.) Given we'll have some time to refine this before 6.3, however, it would be good to restate and revisit these values, and how it relates to menu editing. Given this is a receded view, perhaps the more locked-in structure of the Page List interface fits well with the receded view? Or do we eventually allow a fuller editing interface, similar to what is shipping in the plugin at the moment? There are pros and cons to both. If it's purely a page list:
It would be good to mock up all the flows here to boost our confidence. CC: @WordPress/gutenberg-design |
|
In the 6.2 scope this felt like a potential alternative to what we have on trunk. But since the Navigation panel has been pulled, I agree that we should take the time to continue design explorations. |
|
I look forward to seeing smaller pieces of the various descriptions Joen mentioned. As it fairly quickly goes over my head...:) |
|
For comparison I created a branch I suppose it really depends on where we want this experience to go as to whether we use page list block vs generic menu list. i'd expect the behaviour between lists like templates, template parts, pages and whatever else comes next to be consistent. gutenberg-try.mp4 |
|
I feel really reluctant to call this "Pages", because of its duplication with what's at the top level. I do think there's a future where these two main sections converge in some form or other. But in my mind, the Navigation section is not just about pages, it's also about the Home page, and the Posts page, and the properties we can surface for those two. While those are technically pages, they are also partially templates, making it appropariate to surface them here as something else entirely. To be sure, content access in the site editor has come up a number of times, but if we want to solve that separately from the navigation piece, it should be visually separated from the other main sections, so that it can be denoted as a more temporary thing. I do really like the idea that the plus creates a new page, and I think we can merge that concept with having a "Navigation" or "Structure", or "Sitemap", whatever is the best term. Navigation and "menu" verbiage may have confused people to think that the section is mainly about editing your menu — I see that as an optional bonus to actually surfacing the physical structure of your site. |
|
Closing this until we have a more clear direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast