Block editor: new blockEditor.useBlockProps filter
#48884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Mar 7, 2023
| <BlockListBlock | ||
| { ...props } | ||
| __unstableLayoutClassNames={ layoutClassNames } | ||
| /> |
There was a problem hiding this comment.
To do: use the new filter here too.
There was a problem hiding this comment.
This maybe needs to be a useInnerBlocksProps instead of a useBlockProps filter.
|
Size Change: +61 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
ellatrix
commented
Mar 7, 2023
| isPartOfSelection: isSelected || isPartOfMultiSelection, | ||
| adjustScrolling: | ||
| isSelected || isFirstMultiSelectedBlock( clientId ), | ||
| enableAnimation: | ||
| ! isTyping() && | ||
| getGlobalBlockCount() <= BLOCK_ANIMATION_THRESHOLD, | ||
| blockType: _blockType, | ||
| attributes: _attributes, |
There was a problem hiding this comment.
Maybe we should use context for this, I'm not sure what's best for performance.
ellatrix
force-pushed
the
try/use-block-props-filter
branch
from
b9f2242
to
704f13a
Compare
youknowriad
reviewed
Mar 8, 2023
| @@ -147,9 +152,16 @@ export function useBlockProps( props = {}, { __unstableIsHtml } = {} ) { | |||
| ); | |||
| } | |||
|
|
|||
| const filteredWrapperProps = applyFilters( | |||
There was a problem hiding this comment.
This approach suffers from the hooks rules errors as filters get added/removed over time. I think it's probably going to create a lot of bugs.
gziolo
added
[Feature] Block API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is easier to review without whitespace changes.
Similar to #48809, but for the
BlockListBlockfilter.All use cases for the
editor.BlockListBlockfunction are adding block props. We should create a less powerful (and easier to use) filter specifically for adding block props. With this PR it will be possible to deprecate theeditor.BlockListBlockfilter.Some block support hooks are filtering the
getEditWrapperPropsfunction, we should replace those instances as well.I replaced
__unstableElementContextwith__unstableUseRootPortalwhich allows block support to add SVGs and blocks styles without having to be a component. This is often linked to selectors that need to be added as block props.Why?
Simplifying the block APIs.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast