Update: Add descriptions to all panels in the Site Editor's dark side #48739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
Size Change: +375 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
mtias
reviewed
Mar 3, 2023
| @@ -31,35 +31,40 @@ export default function SidebarNavigationScreenMain() { | |||
| <SidebarNavigationScreen | |||
| isRoot | |||
| title={ __( 'Design' ) } | |||
| description={ __( | |||
| 'Customise your Navigation menus, Templates, and more.' | |||
There was a problem hiding this comment.
should this be "and Styles" instead of "and more"?
mtias
reviewed
Mar 3, 2023
packages/edit-site/src/components/sidebar-navigation-screen-main/index.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Mar 3, 2023
| content={ | ||
| <ItemGroup> | ||
| { !! navigationMenus && navigationMenus.length > 0 && ( | ||
| <> |
There was a problem hiding this comment.
We can remove the fragment right ?
mtias
reviewed
Mar 3, 2023
packages/edit-site/src/components/sidebar-navigation-screen-templates-browse/index.js
Outdated
Show resolved
Hide resolved
mtias
reviewed
Mar 3, 2023
| @@ -51,6 +51,11 @@ export default function SidebarNavigationScreenNavigationItem() { | |||
| icon={ pencil } | |||
| /> | |||
| } | |||
| description={ | |||
| postType === 'page' | |||
| ? __( 'This is a static page.' ) | |||
There was a problem hiding this comment.
Let's do something that helps explain what pages are, if possible. For example, from https://make.wordpress.org/support/user-manual/posts-vs-pages/#about-pages
"Pages are static and are not listed by date. Pages do not use tags or categories."
"Posts are entries listed in reverse chronological order on the site homepage or on the posts page."
|
Would this be a good PR in which to fix the strange alignment?
|
jameskoster
reviewed
Mar 3, 2023
| postType === 'page' | ||
| ? __( 'This is a static page.' ) | ||
| : __( 'This is your posts page' ) | ||
| } | ||
| content={ | ||
| <> | ||
| { post?.link ? ( |
There was a problem hiding this comment.
Not a big deal, but I think it might be better if the ExternalLink appears above the description, closer to the title.
There was a problem hiding this comment.
I actually prefer it below, in fact I consider it a little bit of an awkward affordance to have just for some of the types and not others. I might even suggest removing this link — though that's not at all a strong opinion. Rather, I think we need a separate "view on frontend" affordance somewhere, that's general. Might even be a external link icon that appears when hovering or focusing the frame, or a permanent button, something like that.
|
Flaky tests detected in dfd1c93. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4325475901
|
We can fix this separately, as it's such a small thing. Edit: on the other hand, this needs to be better:
Larger spacing between items, and have the items line up. |
|
Took this one for a spin, and it's so much better — this is a crucial piece to land, let's get this in. Matías left a few comments, let's address those. Then there's a question of whether we need to fix the margin and spacing issues mentioned above in this PR, or separately. |
jorgefilipecosta
force-pushed
the
update/add-descriptions-to-all-panels-in-the-Site-Editors-dark-sidebar
branch
2 times, most recently
from
29dbfbd
to
3b36d78
Compare
…in/index.js Co-authored-by: Matias Ventura <mv@matiasventura.com>
jorgefilipecosta
force-pushed
the
update/add-descriptions-to-all-panels-in-the-Site-Editors-dark-sidebar
branch
from
3b36d78
to
dd46d7e
Compare
|
There is some small overlap between this and #48732 |
|
I applied all the feedback to the descriptions. |
jorgefilipecosta
changed the title
jorgefilipecosta
deleted the
update/add-descriptions-to-all-panels-in-the-Site-Editors-dark-sidebar
branch
3 tasks
Mamaduka
changed the title
Mamaduka
added
the
[Feature] Site Editor
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 976b29e |
ntsekouras
pushed a commit
that referenced
this pull request
Mar 7, 2023
#48739)Co-authored-by: Matias Ventura <mv@matiasventura.com> * Update: Add descriptions to all panels in the Site Editor's dark sidebar. * Update packages/edit-site/src/components/sidebar-navigation-screen-main/index.js Co-authored-by: Matias Ventura <mv@matiasventura.com> --------- Co-authored-by: Matias Ventura <mv@matiasventura.com>
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
added
Backport to WP 6.7 Beta/RC
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48718
Adds descriptions to all browse mode panels.
cc: @jasmussen @jameskoster