Scripts: Fix render.php isn't copied in Windows OS
#48735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
t-hamano
force-pushed
the
fix/scripts-render-windows
branch
from
960be54
to
0a0c2ef
Compare
|
Flaky tests detected in 960be545e95cc1dc2a6e75612e137bd221d248a1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4324988981
|
t-hamano
force-pushed
the
fix/scripts-render-windows
branch
from
0a0c2ef
to
7a7b112
Compare
t-hamano
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
t-hamano
added
[Type] Bug
t-hamano
changed the title
render.php isn't copied in Windows OS
gziolo
approved these changes
Mar 5, 2023
gziolo
pushed a commit
that referenced
this pull request
Mar 6, 2023
* Scripts: Fix `render.php` isn't copied in Windows OS * Update changelog
bph
added
[Tool] Create Block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48696
What?
This PR fixes a problem in which the target file is not copied in Windows when the
renderproperty is defined inblock.json.Why?
The process of finding the file path for
render.phpis done below:gutenberg/packages/scripts/utils/config.js
Lines 332 to 359 in 0766b79
In this process, on Windows, the
filepathvariable has a backslash as the path separator, as shown below:Then I discovered that the
renderPathsvariable created by themap()function has escaped backslashes as array values:The reason for this was that the string could not hold an unescaped backslash, so I suspected it to be automatically escaped in the
map()function.And the path separator characters do not match in the
filterproperty ofCopyWebpackPlugin.gutenberg/packages/scripts/config/webpack.config.js
Lines 277 to 282 in 0420e49
How?
Replaced the path delimiter in the
filepathvariable with a forward slash. As a result, the array values in therenderPathsvariable now also contain forward slashes, and the condition in thefilterproperty works correctly.Testing Instructions
Check out this branch and create a dynamic block template in the project root.
Build the block.
Confirm that the
render.phpfile has been copied to thegutenpride/build/directory.Also, if multiple blocks are created in the
srcdirectory, make sure thatrender.phpfile is generated in each build directory.