Site Editor: Fix the 'Browse all' link in the template details modal #48301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
Feb 22, 2023
Comment on lines
+34
to
+39
| // TODO: We should update this to filter by template part's areas as well. | ||
| const browseAllLinkProps = useLink( { | ||
| // TODO: We should update this to filter by template part's areas as well. | ||
| canvas: 'view', | ||
| postType: template.type, | ||
| postId: undefined, | ||
| path: '/' + template.type + '/all', |
There was a problem hiding this comment.
The broweAllLink version from the sidebar navigation component doesn't work in the edit mode.
Mamaduka
added
[Type] Regression
|
@youknowriad, the new required I'll fix the "Template Parts" link for hybrid themes and include E2E tests to catch similar regressions sooner, but an alternative solution would be to handle this BC breakage somewhere in the router. |
|
Size Change: +17 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Flaky tests detected in 2417357. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4240106350
|
The reason I didn't handle the path is because we now have two template lists pages. The one that shows all the templates in the frame and the one that shows all the templates in the sidebar. So there's an ambiguity about which to load. That said, it's arguable that we could default to "browse all" but it might add some complex logic to |
youknowriad
approved these changes
Feb 22, 2023
|
That's a good point, and I don't think we want to introduce complex logical changes in Linking these pages probably isn't that useful outside of the core cases. I'll create a core patch to fix regression for hybrid themes. |
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: d5dbe59 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #48289.
PR fixes the "Browse" all link in the template details modal.
Why?
The
useLinkhook now requires thepathargument and canvas to be in theviewmode.A possible regression after #48063.
Testing Instructions
Screenshots or screencast